Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

06.using-cards differences in card menu output (buttons in dotnet, list in nodejs) #1732

Closed
emgrol opened this issue Aug 27, 2019 · 2 comments
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@emgrol
Copy link
Contributor

emgrol commented Aug 27, 2019

Sample information

  1. Sample type: \samples\
  2. Sample language: dotnetcore, nodejs
  3. Sample name: 06.using-cards

Describe the bug

The dotnet bot displays buttons for the various card options while the nodejs bot shows a list of card options in a single text box.

To Reproduce

Run bots according to CLI instructions in respective READMEs

Expected behavior

Both bot should display card options menu as buttons, not a list.

Screenshots

dotnet bot: looks good, menu displayed buttons as expected
csharp-cards

nodejs bot: bot displays list instead of buttons
js-cards

Additional context

This may not be an issue with the sample itself and more so with the string formatting in ChoiceFactory.cs/js. @JonathanFingold ran me through the SDK and we came upon this after not seeing an immediately obvious points in the code samples that caused the formatting differences.

@CoHealer CoHealer added the bug Indicates an unexpected problem or an unintended behavior. label Aug 27, 2019
@mdrichardson
Copy link
Contributor

mdrichardson commented Aug 27, 2019

@emgrol I'm unable to repro this. I get the same buttons on both Node and C#.

Node

image

C#

image

  1. Are you using the latest samples?
  2. Are you using the latest version of Emulator? I'm on 4.5.2
  3. Did you make any changes to the samples?

@emgrol
Copy link
Contributor Author

emgrol commented Aug 27, 2019

I didn't make any changes to the samples and I had the latest samples, but it works fine now after updating the Emulator. Thanks for the suggestion, going to close this now that it was just an issue on my end.

@emgrol emgrol closed this as completed Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

No branches or pull requests

3 participants