Skip to content
This repository has been archived by the owner on Jul 19, 2024. It is now read-only.

Not compatible with Bootstrap v4 release 6 #3

Closed
StefanKert opened this issue Jan 7, 2017 · 1 comment
Closed

Not compatible with Bootstrap v4 release 6 #3

StefanKert opened this issue Jan 7, 2017 · 1 comment

Comments

@StefanKert
Copy link
Contributor

When running npm run build following error occures.

image

The reason for this error is, that in package.json, the reference to bootstrap is defined as the following.

"bootstrap": "^4.0.0-alpha.5",

Because of the defined logic for ^ the used package is always the last working package (non breaking Version). The latest version for bootstrap package currently is 4.0.0-alpha.6. The difference between the two versions consists of some files beeing renamed. For the PrivateWebsite this results in an error when performing the command above, because these two packages got renamed

  • _animation.scss -> _transitions.scss #21370
  • _tags.scss -> _badge.scss #21020

The wrong references are defined in scss/vendor/_bootstrap.scss.

There are two possible solutions.

  1. Change reference to bootstrap package in package.json to use specific version
    "bootstrap": "4.0.0-alpha.5",
  2. Change references _scss/vendor/bootstrap.scss to use correct filenames.

I would suggest to use solution 2. because it will fit up to future relases of bootstrap as well as the final release of bootstrap. So for this purpose I am doing a pull request that fixes this issue.

Cheers

@eiximenis
Copy link
Contributor

PR #4 merged.

I close the issue.
Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants