Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that when talking to a local emulator, we don't send requests to remote proxies #3572

Closed
MRayermannMSFT opened this issue Sep 11, 2020 · 0 comments
Closed

Make sure that when talking to a local emulator, we don't send requests to remote proxies #3572

MRayermannMSFT opened this issue Sep 11, 2020 · 0 comments
Assignees
@craxal
Labels
🪲 bug Issue is not intended behavior ⚙️ proxy Related to proxy settings
Milestone
1.16.0

Comments

@MRayermannMSFT
Copy link
Member

If we're sending requests to a local emulator and the current proxy URL is remote, then we shouldn't talk to the proxy server, as it probably won't figure out how to resole localhost/127.0.0.1.

Note: this may be difficult as both the v2 and v12 SDKs pick up env variables and auto set proxy stuff. So maybe we have to stop using the "well known" proxy env vars?
@MRayermannMSFT MRayermannMSFT added 🪲 bug Issue is not intended behavior ⚙️ proxy Related to proxy settings labels Sep 11, 2020
@MRayermannMSFT MRayermannMSFT added this to the 1.16.0 milestone Sep 11, 2020
@craxal craxal changed the title Make sure that when talking to a local emulator, we don't send requests to remove proxies Make sure that when talking to a local emulator, we don't send requests to remote proxies Oct 1, 2020
@craxal craxal closed this as completed Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@craxal craxal

Labels
🪲 bug Issue is not intended behavior ⚙️ proxy Related to proxy settings
Projects
None yet
Milestone
1.16.0
Development

No branches or pull requests
2 participants
@craxal @MRayermannMSFT