Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make StorageExplorer.exe file version match product version #2941

Closed
schenardie opened this issue May 7, 2020 · 4 comments
Closed

Make StorageExplorer.exe file version match product version #2941

schenardie opened this issue May 7, 2020 · 4 comments
Assignees
Labels
💡 feature request New feature or request
Milestone

Comments

@schenardie
Copy link

Not sure if thats the right place or if its too much to ask but would be very nice to have the storage explorer executable (StorageExplorer.exe) file version to match the product version. Or at least make that information available at https://api.github.com/repos/microsoft/AzureStorageExplorer/releases/latest/

It would make life a lot easier when packaging the software for enterprise deployment (for detection pursposes).

Thanks

@craxal craxal added the 💡 feature request New feature or request label May 9, 2020
@MRayermannMSFT
Copy link
Member

@schenardie what do you mean by the "file version"? Do you mean having the version in the file name, or do you mean like the file properties? Also, are you asking for this to be on the installer or the executable that ends up in your program files directory?

@schenardie
Copy link
Author

hey @MRayermannMSFT, i'm talking about the file properties of the executable (StorageExplorer.exe).
The file currently has Product Version (1.13.1) and File version (15427.1.0.0).
Management systems like SCCM and Intune are based on file version for detection. Currently i cant tell what the next version will be, so it makes hard to automate this packaging.

Most of MS tools like VSCode have the same value for both. If that is not doable, maybe putting a property on the intune api per release informing the version would suffice (so we can probe that information). Thanks

@MRayermannMSFT MRayermannMSFT added this to the 1.15.0 milestone Jun 1, 2020
@MRayermannMSFT MRayermannMSFT modified the milestones: 1.15.0, 1.16.0 Jun 15, 2020
@JasonYeMSFT JasonYeMSFT modified the milestones: 1.16.0, 1.18.0 Sep 3, 2020
@MRayermannMSFT MRayermannMSFT modified the milestones: 1.18.0, 1.19.0 Dec 14, 2020
@craxal
Copy link
Contributor

craxal commented Feb 26, 2021

electron-packager uses rcedit internally to set up the .exe, but it doesn't let us define the file version explicitly. It's always filled in with the build version. The weird thing is the build version appears to be wrong; I don't know where it's getting that number from. As far as solutions go, we may need to use rcedit directly to get what we want.

@craxal craxal changed the title Standardise StorageExplorer.exe file Make StorageExplorer.exe file version match product version Feb 26, 2021
@MRayermannMSFT MRayermannMSFT modified the milestones: 1.19.0, 1.20.0 Mar 2, 2021
@MRayermannMSFT
Copy link
Member

Moving this due to changes in dev resources for 1.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants