Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side effects of switching to FrameworkReference #2359

Closed
TimothyMothra opened this issue Aug 10, 2021 · 1 comment
Closed

Side effects of switching to FrameworkReference #2359

TimothyMothra opened this issue Aug 10, 2021 · 1 comment
Milestone

Comments

@TimothyMothra
Copy link
Member

This issue is to track extra changes due to #2355

We're switching projects to use FrameworkReference wherever possible. link

Several AspNetCore packages will no longer be published in favor of FrameworkReference.
This simplifies our dependencies and ensures that we're always using the latest version of a library.

This change had some conflicts in our test projects.

  • AzureInstanceMetadataEndToEndTests depends on AzureInstanceMetadataServiceMock which creates an in-proc server to handle HTTP requests.
    This is being addressed in a separate issue AzureInstanceMetadata: replace tests #2357

  • Microsoft.ApplicationInsights.AspNetCore.Tests.csproj

    'IHostingEnvironment' is obsolete: 'This type is obsolete and will be removed in a future version.
    The recommended alternative is Microsoft.AspNetCore.Hosting.IWebHostEnvironment.'

@TimothyMothra TimothyMothra added this to the 2.19 milestone Aug 10, 2021
@TimothyMothra
Copy link
Member Author

closing this. i moved these details back into #2251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant