Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC Typed Schema files not valid JSON Schema #9058

Open
cwacek opened this issue Nov 15, 2024 · 0 comments
Open

AC Typed Schema files not valid JSON Schema #9058

cwacek opened this issue Nov 15, 2024 · 0 comments

Comments

@cwacek
Copy link

cwacek commented Nov 15, 2024

Why bother providing jsonschema definitions for AdaptiveCard and friends (and advertising it prominently) when the schema's aren't actually valid?

Discussed in #8943

Originally posted by jamesthurley June 26, 2024
For example this file:

https://github.com/microsoft/AdaptiveCards/blob/main/schemas/src/enums/ImageSize.json

Says it uses this schema:

https://raw.githubusercontent.com/microsoft/AdaptiveCards/6f39aedce45864ae1067ed44a5551dc973790bb5/source/nodejs/typed-schema/schema/lib/Type.json

But it isn't valid against that schema. It contains an extra description property, and is missing the type property. Have the schemas for the ac-typed-schema JSON been abandoned? Would a PR to update them be appreciated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant