Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Freeway-Bug}[Adaptive Cards - Activity Update] - Ensures role attribute has an appropriate value for the element. #8350

Closed
vagpt opened this issue Mar 7, 2023 · 3 comments · Fixed by #8512
Labels
A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yTTValidated A11yWCAG Accessibility issue that affects compliance AdaptiveCards_Web a11y tag Area-Accessibility Bugs around feature accessibility Area-Renderers Bug HCL-AdaptiveCards-Web Used by accessibility team for scorecard categorization HCL-E+D Product-AC

Comments

@vagpt
Copy link
Collaborator

vagpt commented Mar 7, 2023

Target Platforms

Other

SDK Version

1.5

Application Name

Adaptive Cards

Problem Description

Test Environment:
OS: Version 22H2 (OS Build 25300.1000)
URL: https://adaptivecards.io/samples/ActivityUpdate.html
Browser: Edge Dev Version 111.0.1661.36 (Official build) dev (64-bit)
Screen Reader: Narrator

Repro Steps:

  1. Open the above URL in edge dev browser.
  2. Turn on the fast pass of accessibility insights for web.
  3. Observe the issue.

Actual Result:
Role attribute does not have an appropriate value for the element.

Expected Result:
Ensures role attribute should have an appropriate value for the element.

Snippet:
< open anchor tag >role="listitem" class="selectedHolder" aria-current="true" aria-posinset="1" aria-setsize="29" href="/samples/ActivityUpdate.html">Activity update

How to fix:
Fix any of the following:
ARIA role listitem is not allowed for given element

User Impact:
Screen reader user will get impacted if incorrect role is defined due to which user will not be able to understand the purpose of the content easily.

WCAG Reference link:
https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships.html

“Have feedback to share on Bugs? Please help fill Trusted Tester Bug Feedback (office.com)

Screenshots

image

WCAG4 1 2-Ensures role attribute has an appropriate value for the element

Card JSON

NA

Sample Code Language

No response

Sample Code

No response

@vagpt vagpt added Bug Area-Renderers Area-Accessibility Bugs around feature accessibility A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yWCAG Accessibility issue that affects compliance HCL-E+D Product-AC HCL-AdaptiveCards-Web Used by accessibility team for scorecard categorization labels Mar 7, 2023
@vagpt vagpt changed the title [Adaptive Cards - Activity Update] - Ensures role attribute has an appropriate value for the element. {Freeway-Bug}[Adaptive Cards - Activity Update] - Ensures role attribute has an appropriate value for the element. Mar 14, 2023
@vagpt
Copy link
Collaborator Author

vagpt commented Jun 8, 2023

Reactivating this issue as this issue is still repro on the environment below.

Test Environment:
OS: Version 23H2 (OS Build 25381.1)
URL: https://adaptivecards.io/samples/ActivityUpdate.html
Browser: Edge Dev Version 115.0.1880.3 (Official build) dev (64-bit)
Screen Reader: Narrator

Snippet:

image

@anna-dingler
Copy link
Contributor

Hi @vagpt,

We just made a release of our website, and this change should now be available. Thanks!

@vagpt
Copy link
Collaborator Author

vagpt commented Sep 5, 2023

This issue is not repro on the environment below, hence closing this issue.

Test Environment:
URL: https://adaptivecards.io/designer/
OS Version: 23H2(OS Build 25931.1000)
Browser Version: 118.0.2060.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yTTValidated A11yWCAG Accessibility issue that affects compliance AdaptiveCards_Web a11y tag Area-Accessibility Bugs around feature accessibility Area-Renderers Bug HCL-AdaptiveCards-Web Used by accessibility team for scorecard categorization HCL-E+D Product-AC
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants