Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][Column Rendering] Column Bleed crashes #5050

Closed
1 task
almedina-ms opened this issue Nov 5, 2020 · 2 comments · Fixed by #5055
Closed
1 task

[Android][Column Rendering] Column Bleed crashes #5050

almedina-ms opened this issue Nov 5, 2020 · 2 comments · Fixed by #5055
Assignees
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug High Priority Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android)
Milestone

Comments

@almedina-ms
Copy link
Contributor

almedina-ms commented Nov 5, 2020

Platform

  • Android

Author or host

Version of SDK

2.3.0

Details

Due to the change of implementation from LinearLayout to FlexboxLayout, the application of Bleed property is failing for columns. The fix should be made in ContainerRenderer.ApplyBleed to add support for this type of containers.

Json v1.2\Elements\Column.Bleed

{
	"type": "AdaptiveCard",
	"body": [
		{
			"type": "TextBlock",
			"text": "Bleed left"
		},
		{
			"type": "ColumnSet",
			"style": "emphasis",
			"columns": [
				{
					"type": "Column",
					"style": "good",
					"items": [
						{
							"type": "TextBlock",
							"text": "Column 1"
						}
					],
					"bleed": true,
					"width": "stretch"
				},
				{
					"type": "Column",
					"style": "attention",
					"items": [
						{
							"type": "TextBlock",
							"text": "Column 2"
						}
					],
					"width": "stretch"
				},
				{
					"type": "Column",
					"style": "warning",
					"items": [
						{
							"type": "TextBlock",
							"text": "Column 3"
						}
					],
					"width": "stretch"
				}
			]
		},
		{
			"type": "TextBlock",
			"text": "Bleed center"
		},
		{
			"type": "ColumnSet",
			"style": "emphasis",
			"columns": [
				{
					"type": "Column",
					"style": "good",
					"items": [
						{
							"type": "TextBlock",
							"text": "Column 1"
						}
					],
					"width": "stretch"
				},
				{
					"type": "Column",
					"style": "attention",
					"items": [
						{
							"type": "TextBlock",
							"text": "Column 2"
						}
					],
					"bleed": true,
					"width": "stretch"
				},
				{
					"type": "Column",
					"style": "warning",
					"items": [
						{
							"type": "TextBlock",
							"text": "Column 3"
						}
					],
					"width": "stretch"
				}
			]
		},
		{
			"type": "TextBlock",
			"text": "Bleed right"
		},
		{
			"type": "ColumnSet",
			"style": "emphasis",
			"columns": [
				{
					"type": "Column",
					"style": "good",
					"items": [
						{
							"type": "TextBlock",
							"text": "Column 1"
						}
					],
					"width": "stretch"
				},
				{
					"type": "Column",
					"style": "attention",
					"items": [
						{
							"type": "TextBlock",
							"text": "Column 2"
						}
					],
					"width": "stretch"
				},
				{
					"type": "Column",
					"style": "warning",
					"items": [
						{
							"type": "TextBlock",
							"text": "Column 3"
						}
					],
					"bleed": true,
					"width": "stretch"
				}
			]
		},
		{
			"type": "TextBlock",
			"text": "Bleed all"
		},
		{
			"type": "ColumnSet",
			"style": "emphasis",
			"columns": [
				{
					"type": "Column",
					"style": "good",
					"items": [
						{
							"type": "TextBlock",
							"text": "Column 1"
						}
					],
					"bleed": true,
					"width": "stretch"
				},
				{
					"type": "Column",
					"style": "attention",
					"items": [
						{
							"type": "TextBlock",
							"text": "Column 2"
						}
					],
					"bleed": true,
					"width": "stretch"
				},
				{
					"type": "Column",
					"style": "warning",
					"items": [
						{
							"type": "TextBlock",
							"text": "Column 3"
						}
					],
					"bleed": true,
					"width": "stretch"
				}
			]
		}
	],
	"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
	"version": "1.0"
}

@almedina-ms almedina-ms added the Bug label Nov 5, 2020
@ghost ghost added this to the 20.11 milestone Nov 5, 2020
@ghost ghost added the Area-Inconsistency Bugs around renderer inconsistencies across different platforms label Nov 5, 2020
@ghost
Copy link

ghost commented Nov 5, 2020

please review this issue for target Milestone, Inconsistencies & Priority upon triage.

@ghost ghost added the AdaptiveCards v20.11 label Nov 5, 2020
@shalinijoshi19 shalinijoshi19 added Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner labels Nov 6, 2020
@ghost ghost added the Status-In Code Review label Nov 6, 2020
@RebeccaAnne RebeccaAnne modified the milestones: 20.11, 20.12 Nov 10, 2020
@ghost ghost removed the AdaptiveCards v20.11 label Nov 10, 2020
@shalinijoshi19 shalinijoshi19 modified the milestones: 20.12, 20.11 Nov 16, 2020
@ghost ghost added the AdaptiveCards v20.11 label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug High Priority Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants