Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility Issues from Teams Mobile] - Random Order in Reading out Elements #3712

Closed
VikrantSingh01 opened this issue Jan 9, 2020 · 18 comments
Assignees
Labels
Area-Accessibility Bugs around feature accessibility Blocked Label to indicate progress on an issue is blocked on another dependent issue Bug High Priority MSTeams-Developer-Support [DoNotDelete] Label to notify questions which needs attention from MSTeams Developer Support team. Needs: Author Feedback Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Platform-iOS Resolution-No Repro
Milestone

Comments

@VikrantSingh01
Copy link

VikrantSingh01 commented Jan 9, 2020

Platform

What platform is your issue or question related to? (Delete other platforms).

  • iOS

Author or host

Teams Mobile Client.

Version of SDK

1.2.5

Details

Issue :
Creating Another bug to track the Pending Accessibility Issues from #3271

The main issue is the order of the reading out the accessibility elements is random on iOS.

Internal Teams Work Item :
https://domoreexp.visualstudio.com/MSTeams/_workitems/edit/607780

CC - @nesalang @shalinijoshi19 @arpitgupta19 @Aditya0603 @siduppal

@ghost ghost added the Triage-Needed label Jan 9, 2020
@VikrantSingh01
Copy link
Author

VikrantSingh01 commented Jan 9, 2020

Action Plan : CC - @shalinijoshi19

@nesalang to add loggers to the Adaptive Card SDK and share the logging enabled Binary to debug the accessibility from our Client. Kindly send a note to the team with the updated binary once ready.

@Aditya0603 / @shbhadra : To Share the Teams (with instrumented Adaptive Card Library) .apk and .ipa and .app to run the Android and iOS Simulator. (with Instruction).

@VikrantSingh01 VikrantSingh01 added Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Priority-Urgent Area-Accessibility Bugs around feature accessibility Platform-iOS labels Jan 9, 2020
@VikrantSingh01 VikrantSingh01 changed the title Accessibility Issues from Teams Mobile Client. [Accessibility Issues from Teams Mobile] - Random Order in Reading out Elements Jan 9, 2020
@ghost ghost removed the Triage-Needed label Jan 9, 2020
@shalinijoshi19
Copy link
Member

@nesalang how are we looking on the private framework package we needed to provide to the teams team for debugging?

@jwoo-msft
Copy link
Member

jwoo-msft commented Jan 16, 2020

@nesalang how are we looking on the private framework package we needed to provide to the teams team for debugging?

i'm checking out apple's apis for accessibility information. hoping to create a PR today. after quick chat with Aditya there were few things we could address right away without needing to log to help the Teams. I'm looking at those, too.

@shalinijoshi19
Copy link
Member

shalinijoshi19 commented Jan 24, 2020

@nesalang has a PR out #3727 that will now get committed to master. Once that is in, @nesalang generates the final artifact (Framework private package) that @Aditya0603 will be testing out with next week.

@VikrantSingh01
Copy link
Author

@nesalang / @shalinijoshi19 : Kindly let us know once this accessibility fix is out. We would like to do integrate this along with frictionless update P.R (via Cocopad). CC - @Aditya0603 / @shbhadra

@shalinijoshi19
Copy link
Member

@VikrantSingh01 release/1.2 branch has the changes merged in a this point. @nesalang is there a framework file that we can share with Teams built out of hte code currently in release/1.2? Thanks!

@jwoo-msft
Copy link
Member

@VikrantSingh01 release/1.2 branch has the changes merged in a this point. @nesalang is there a framework file that we can share with Teams built out of hte code currently in release/1.2? Thanks!

@shalinijoshi19 & @VikrantSingh01 here is the link to the artifact.

@VikrantSingh01
Copy link
Author

@arpitgupta19 : Can we get this verified with the list of accessibility issues we have in our Mobile queue

@jwoo-msft
Copy link
Member

@nesalang check on the status with the accessibility log addition.

@Subhasish-msft Subhasish-msft added the MSTeams-Developer-Support [DoNotDelete] Label to notify questions which needs attention from MSTeams Developer Support team. label Apr 2, 2020
@shalinijoshi19
Copy link
Member

@VikrantSingh01 could you help follow up on this one to see if the additional logging support here helped ?

@adumrewal
Copy link

@jwoo-msft, @shalinijoshi19 : I can still experience this issue with SDK 1.2.7 on Teams iOS. For example, if a card has ActionSet/ChoiceSet (compact style), the order is not being followed correctly.
VoiceOverVideo

@jwoo-msft
Copy link
Member

@adumrewal, could you please repro this issue with same payload and accessibility inspector enabled, and share the log you collect?
@anbah34

Thanks

@shalinijoshi19
Copy link
Member

@VikrantSingh01 / @anbah34 / @adumrewal ping. Thanks

@ghost
Copy link

ghost commented Aug 10, 2020

Hello @VikrantSingh01! We need some additional information from you to process this issue. Please see discussion comments above. Thanks!

@jwoo-msft jwoo-msft added this to the 20.10 milestone Oct 12, 2020
@jwoo-msft jwoo-msft assigned jwoo-msft and unassigned Wajeed-msft Oct 12, 2020
@shalinijoshi19 shalinijoshi19 added the Blocked Label to indicate progress on an issue is blocked on another dependent issue label Oct 21, 2020
@jwoo-msft
Copy link
Member

@adumrewal
hi,

Can you share the payload shown in your video, so I can try it on my end? With the payload I have, I couldn't reproduce the issue with main branch.

Can you also share a video with audio? It's really hard to figure out what's the issue. Please also provide steps you've taken to reproduce the issue.

I think we should only concerned about one card at a time. In the video, the focus was moving to another card, that's not something AdaptiveCard SDK can control. You might have to set the focus again on the row that comes into the view.

Thanks

@ghost ghost added the AdaptiveCards v20.10 label Oct 22, 2020
@shalinijoshi19
Copy link
Member

Closing this out for now as it isn't a 1.3 upgrade blocker and we havent had traction on this for a while. @VikrantSingh01 / @adumrewal can you reactivate if this still continues to repro with latest bits pls?
Thanks

@adumrewal
Copy link

I tested this with the latest main branch and I'm unable to repro it there. Looks like a Teams client specific issue.

@jwoo-msft
Copy link
Member

I tested this with the latest main branch and I'm unable to repro it there. Looks like a Teams client specific issue.

cc @shalinijoshi19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Bugs around feature accessibility Blocked Label to indicate progress on an issue is blocked on another dependent issue Bug High Priority MSTeams-Developer-Support [DoNotDelete] Label to notify questions which needs attention from MSTeams Developer Support team. Needs: Author Feedback Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Platform-iOS Resolution-No Repro
Projects
None yet
Development

No branches or pull requests

7 participants