Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOS][Layout] verticalContentAlignment with "center" doesn't take effect in container #3581

Closed
FelixZhang001 opened this issue Nov 8, 2019 · 6 comments · Fixed by #3630
Closed
Assignees
Labels
Bug Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Platform-iOS

Comments

@FelixZhang001
Copy link

Platform

  • iOS

Author or host

Host - Teams IOS

Version of SDK

latest master.

Details

Tried to use adaptive card lastest master branch sample app to test below payload.
Seems that "verticalContentAlignment": "center" doesn't take effect and the avatar image position is not correct.

{
"type": "AdaptiveCard",
"version": "1.0",
"body": [
{
"type": "Container",
"items": [
{
"type": "ColumnSet",
"columns": [
{
"type": "Column",
"width": "Auto",
"items": [
{
"type": "TextBlock",
"weight": "bolder",
"text": "To",
"wrap": true
}
],
"verticalContentAlignment": "center"
},
{
"type": "Column",
"width": "Auto",
"items": [
{
"type": "Image",
"size": "small",
"style": "person",
"url": "https://pbs.twimg.com/profile_images/3647943215/d7f12830b3c17a5a9e4afcc370e3a37e_400x400.jpeg"
}
],
"spacing": "small",
"verticalContentAlignment": "center"
},
{
"type": "Column",
"width": "Auto",
"items": [
{
"type": "TextBlock",
"text": "Mu Yang",
"wrap": true
}
],
"verticalContentAlignment": "center"
}
]
},
{
"type": "Input.Text",
"id": "message",
"placeholder": "Enter Message",
"isMultiline": true
}
]
}
],
"actions": [
{
"type": "Action.Submit",
"data": {
"ux_send": "true",
"intent:confirm": "true"
},
"title": "Send"
},
{
"type": "Action.Submit",
"data": {
"intent:cancel": "true"
},
"title": "Cancel"
}
]
}

Screen Shot 2019-11-08 at 4 25 22 PM

@ghost ghost added the Triage-Needed label Nov 8, 2019
@shalinijoshi19 shalinijoshi19 added Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner labels Nov 11, 2019
@ghost ghost removed the Triage-Needed label Nov 11, 2019
@shalinijoshi19
Copy link
Member

@nesalang could you take a first stab pls? Thanks

@shalinijoshi19
Copy link
Member

@nesalang is looking into this. Thanks

@shalinijoshi19
Copy link
Member

@nesalang does this need to be ported into master?

@shalinijoshi19
Copy link
Member

Please go ahead and close once it' checked into master.. thanks! (unsure why despite using the fixes keyword the issue wasnt closed out automatically)

@jwoo-msft
Copy link
Member

BB Payload
samples/v1.1/Test
Column.VerticalAlignment.json

@ghost
Copy link

ghost commented Nov 27, 2019

🎉[email protected] has been released which fixes this issue.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Platform-iOS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants