Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shared model] There is no consistency for on and off values in Input.Toggle #3224

Closed
almedina-ms opened this issue Jul 12, 2019 · 3 comments · Fixed by #3227
Closed

[Shared model] There is no consistency for on and off values in Input.Toggle #3224

almedina-ms opened this issue Jul 12, 2019 · 3 comments · Fixed by #3227
Assignees
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug Platform-Shared Model

Comments

@almedina-ms
Copy link
Contributor

Platform

  • Shared

Version of SDK

latest master

Issue

In a Input.Toggle input object the default value, when creating the element, for valueOn is "true" and for valueOff is "false" but when serializing we check for empty strings for default values which is not the same; the Deserialize method in the other hand considers empty string to be the default values for both properties, which should be the default value?

@almedina-ms
Copy link
Contributor Author

@andrewleader @paulcam206 @RebeccaAnne , any ideas here?

@andrewleader
Copy link
Contributor

In the schema we say default values are "true" and "false" if the author didn't specify those properties, I'd say we should converge around that?

@ghost
Copy link

ghost commented Sep 26, 2019

🎉[email protected] has been released which fixes this issue.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug Platform-Shared Model
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants