Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to tag display in templates "breaks" existing PnP Search Results Web Parts #4039

Closed
sympmarc opened this issue Oct 11, 2024 · 7 comments
Assignees
Labels
bug Something isn't working Needs: Triage Needs investigation and repro

Comments

@sympmarc
Copy link
Contributor

Version used
Ex: 4.13.1 (latest)

Describe the bug
The change in this release to better format tags causes a change in the way the settings need to be to display the tags well.

In the past, we had to add "Auto" before owstaxismetatdataalltagsinfo and then turn on localization for the tags to look right - not show the full object. If these settings are in place when we upgrade to 4.13.0, the tags are not displayed at all - just the tag image.

To Reproduce
Described above.

Expected behavior
Tags set up should work the same as before - existing Web Parts shouldn't have to be changed. What worries me is as people start upgrading to 4.13.0, they will see their tags as "broken", rather than seeing the improved display.

Additional context
Talked to @kasperbolarsen about this on a call - he's aware of the issue and asked me to post.

The template changes were in Simple List and maybe one other template, as discussed in #3806.

@wobba
Copy link
Collaborator

wobba commented Oct 12, 2024

@kasperbolarsen is this due to the template change?

@wobba wobba added bug Something isn't working Needs: Triage Needs investigation and repro labels Oct 12, 2024
@kasperbolarsen
Copy link
Collaborator

@kasperbolarsen is this due to the template change?

Yes, I think so.
I guess the recommended way to use these is to use the taxid version and the Auto along with localization?

@wobba
Copy link
Collaborator

wobba commented Oct 14, 2024

Yes, auto is needed for localization. @kasperbolarsen are you able to do a PR on this or do you need assistance?

@kasperbolarsen
Copy link
Collaborator

I have a good candidate ready and will validate it again the reported scenario, but will welcome a review

@sympmarc
Copy link
Contributor Author

sympmarc commented Nov 8, 2024

@kasperbolarsen Any idea when this fix might be released? Would you like any help testing?

@wobba
Copy link
Collaborator

wobba commented Nov 8, 2024

@sympmarc I can merge the down branch into a new release. So if you build the dev branch and test that should be sufficient.

@wobba
Copy link
Collaborator

wobba commented Nov 12, 2024

Should be fixed in the latest release.

@wobba wobba closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Needs: Triage Needs investigation and repro
Projects
None yet
Development

No branches or pull requests

3 participants