-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to tag display in templates "breaks" existing PnP Search Results Web Parts #4039
Comments
@kasperbolarsen is this due to the template change? |
Yes, I think so. |
Yes, auto is needed for localization. @kasperbolarsen are you able to do a PR on this or do you need assistance? |
I have a good candidate ready and will validate it again the reported scenario, but will welcome a review |
@kasperbolarsen Any idea when this fix might be released? Would you like any help testing? |
@sympmarc I can merge the down branch into a new release. So if you build the dev branch and test that should be sufficient. |
Should be fixed in the latest release. |
Version used
Ex: 4.13.1 (latest)
Describe the bug
The change in this release to better format tags causes a change in the way the settings need to be to display the tags well.
In the past, we had to add "Auto" before owstaxismetatdataalltagsinfo and then turn on localization for the tags to look right - not show the full object. If these settings are in place when we upgrade to 4.13.0, the tags are not displayed at all - just the tag image.
To Reproduce
Described above.
Expected behavior
Tags set up should work the same as before - existing Web Parts shouldn't have to be changed. What worries me is as people start upgrading to 4.13.0, they will see their tags as "broken", rather than seeing the improved display.
Additional context
Talked to @kasperbolarsen about this on a call - he's aware of the issue and asked me to post.
The template changes were in Simple List and maybe one other template, as discussed in #3806.
The text was updated successfully, but these errors were encountered: