Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Results and Search Filters webparts doesn't load using mobile device #3505

Open
sherpas-par opened this issue Feb 7, 2024 · 12 comments
Labels
bug Something isn't working Needs: Triage Needs investigation and repro

Comments

@sherpas-par
Copy link
Contributor

Version used
4.10.2.0

Describe the bug
When using mobile device, in my case Apple iPhone, Search results and Search Filters webparts doesn't load, only showing error: undefined is not an object (evaluating 'e.isInternal').

Used these web browsers, Apple Safari and Microsoft Edge. I've also tried using Microsoft SharePoint App for iOS.

To Reproduce
Detailed steps to reproduce the behavior:

  1. Go to SharePoint Online page with configured Modern Search webparts, Search Results and Search Filters using mobile device
  2. See error

Expected behavior
Search Result and Search Filters webpart should load correctly and display content.

Screenshots
Error message when using 4.10.x.0
image

Desktop (please complete the following information):
Apple iOS 17.3

  • Browser Safari and Edge (both are running Apple WebKit)

Additional context
Tried Modern Search 4.9.3.0 and I cannot reproduce the problem with that version.
image

I've also tried Modern Search 4.10.1.0 and the same issue occurs as with 4.10.2.0

@kasperbolarsen
Copy link
Collaborator

kasperbolarsen commented Feb 9, 2024

I tried to recreate the issue on my Samsung s22, Android 14, and I had no issues at all.

@sherpas-par will you be able to verify my findings from an android device?

@sherpas-par
Copy link
Contributor Author

sherpas-par commented Feb 13, 2024

I have tried now with two different phones:

  • Samsung S22, Android 14, Google Chrome - Working
  • OnePlus 9 Pro, Android 13, Google Chrome - Not working

@wobba
Copy link
Collaborator

wobba commented Feb 13, 2024

I can repro the issue on my iPhone, but not sure how to debug and fix it... as the error is coming from sppages and not the web parts themselves.

@wobba wobba added bug Something isn't working Needs: Triage Needs investigation and repro labels Feb 13, 2024
@wobba
Copy link
Collaborator

wobba commented Feb 13, 2024

Seems to work if I turn of use of GraphToolkit, so related to that somehow and not sure I want to dig into this at all :)

@DavidD410
Copy link

Seems to work if I turn of use of GraphToolkit, so related to that somehow and not sure I want to dig into this at all :)

Can you clarify this, please ?

@patrikhellgren
Copy link
Contributor

I can reproduce this using Edge on Windows by clearing the cache and reloading the page.
And also by instead adding sw=bypass to the querystring.

@wobba
Copy link
Collaborator

wobba commented Feb 19, 2024

@patrikhellgren any ideas on how to solve it? And what does sw=bypass do?

@patrikhellgren
Copy link
Contributor

@wobba Unfortuantely I don´t know how to solve this yet but after checking the network calls it seems to be some issue with authentication/token handling for Graph within MGT when used in this way. I could try to do a quick upgrade to MGT 4 to see if that resolves it and get back here with the results.

I guess it is not documented what sw=bypass exactly does but it seems to instruct SharePoint to bypass the service worker caching mechanism. It seems to be the go-to thing to try when there are strange behavior and/or cache related stuff occuring. Lots of issues in SharePoint/sp-dev-docs references this. In this case I just tried that since this seemed somewhat caching related because of it being reproducable when clearing the cache and reloading the page.

@DavidD410
Copy link

@wobba Unfortuantely I don´t know how to solve this yet but after checking the network calls it seems to be some issue with authentication/token handling for Graph within MGT when used in this way. I could try to do a quick upgrade to MGT 4 to see if that resolves it and get back here with the results.

I guess it is not documented what sw=bypass exactly does but it seems to instruct SharePoint to bypass the service worker caching mechanism. It seems to be the go-to thing to try when there are strange behavior and/or cache related stuff occuring. Lots of issues in SharePoint/sp-dev-docs references this. In this case I just tried that since this seemed somewhat caching related because of it being reproducable when clearing the cache and reloading the page.

For information, if it helps you, even a page with a simple "Search box" web part shows the error message...

@wobba
Copy link
Collaborator

wobba commented Feb 20, 2024

At least there is a way to trigger this for repro.. a start :)

@DavidD410
Copy link

DavidD410 commented Feb 26, 2024

The problem also appears when using Teams on mobile/smartphone, whereas with 4.8 everything is ok :

Photo sélectionnée (5)

@wobba
Copy link
Collaborator

wobba commented Feb 27, 2024

@DavidD410 different graph toolkit versions, and the PR pushed will likely resolve this. You can build the dev branch and test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Needs: Triage Needs investigation and repro
Projects
None yet
Development

No branches or pull requests

5 participants