-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MicroProfile Config 2.0 Specification Review #9
Comments
+1 |
Received +1 from PMC Gunnar Wagenknecht [email protected] via eclipse.org | Gunnar Wagenknecht [email protected] via eclipse.org | Wed, Nov 18, 7:00 PM (1 day ago) |
Can you add the link into the description, so it gets more visibility? |
+1 |
+1 |
We forgot to include the final step, the Result Ballot notification after the initiated ballot is sent. Thank YOU! the general template needs to be adjusted as well. :) |
+1 for Jelastic |
Making a similar comment that I did on the Metrics #15 and Health #14 Issues... We need the Compatible Implementation that is used to verify the CCR to be more "permanent". There is a reference to SmallRye Config 2.0. Is this available in Maven or some permanent download location? A link would be good, if that's the case. Otherwise, we should create the SmallRye Config 2.0 artifact, store it, and provide a link. Thanks. |
Hey @kwsutter. It is available as a commit in the repo: The issue here is somehow the same you have with dependent specs. We can't really do a release of the implementation without having the API publicly available. Once the API is out, we cut a release from the same codebase but without the staging repo reference and publish it in Maven Central. The link can then be replaced by the permanent binary in Central. Is this acceptable? |
@radcortez, the commit tag by itself is not sufficient. This would still require someone to download the exact code and build it in the exact same way in order to produce the binary. As time goes on, these processes will get muddled and the building will become more difficult. Any Compatible Implementation needs to have a long life. It could be a Milestone driver, or a Release Candidate driver, or even a Snapshot driver -- as long as the binary has some repository where it will live and not accidentally get deleted. The best location is Maven. But, other long-lived download repos will also suffice. I agree that it's a chicken-and-egg problem. We struggle with this at Jakarta as well. But, we need to have a long-lived CI that can be used at a later time to verify the compatibility. As an example, Jakarta EE 9 used Glassfish 6.0-RC2 as the CI. Some of the embedded implementations used by Glassfish had not finalized their versions yet. As soon as all of these are completed, then Glassfish v6.0 (final) will be used to re-certify as the CI. A new CCR will be filed and the data for the Jakarta EE 9 CI will be updated with the new information (added to, not replaced). |
Ok, updated the CCR with a RC release available in Central. |
I double checked the released and confirmed the release used the staged Config 2.0 api (see here) and passed the TCK. |
This is now in Maven Central: https://repo1.maven.org/maven2/org/eclipse/microprofile/config/microprofile-config-api/2.0/ |
Specification issue template
When creating a specification project release review, create an issue in the MicroProfile-WG repository repo with the content defined as follows.
Release Review
The text was updated successfully, but these errors were encountered: