Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MicroProfile Config 2.0 Specification Review #9

Closed
22 tasks done
Emily-Jiang opened this issue Nov 18, 2020 · 15 comments
Closed
22 tasks done

MicroProfile Config 2.0 Specification Review #9

Emily-Jiang opened this issue Nov 18, 2020 · 15 comments
Labels
ballot Release Review, Plan Review, Progress Review issue is now in ballot and should not be updated emo-approved EF EMO has approved the lifecycle issue final Release Review, Plan Review, Progress Review issue is ready for ballot in the eyes of the Spec team pmc-approved EF PMC has approved the lifecycle issue Release Review wg-approved MP WG has approved the lifecycle issue

Comments

@Emily-Jiang
Copy link
Member

Emily-Jiang commented Nov 18, 2020

Specification issue template

When creating a specification project release review, create an issue in the MicroProfile-WG repository repo with the content defined as follows.

  • Specification name and version
  • Add the label Release Review
  • Naming conventions for artifacts:
    • Specification PDF in the form of microprofile-project-spec-version.pdf
    • Specification HTML in the form of microprofile-project-spec-version.html
    • project is the microprofile specification short project name (config, health, ...)
    • version is the two digit x.y version of the specification

  • The Nexus Staging links (orgeclipsemicroprofile-NNNN where NNNN is the staging repository id) (eg, https://oss.sonatype.org/content/repositories/orgeclipsemicroprofile-NNNN/org/eclipse/microprofile/config/) which contain all the binaries and relevant documentation:

  • Summary that a Compatible Implementation is complete, passes the TCK, and that the TCK includes sufficient coverage of the specification:

@radcortez
Copy link

+1

@radcortez
Copy link

/cc @jclingan @ederks85 @emecas

@Emily-Jiang Emily-Jiang added the pmc-approved EF PMC has approved the lifecycle issue label Nov 19, 2020
@Emily-Jiang
Copy link
Member Author

Received +1 from PMC

Gunnar Wagenknecht [email protected] via eclipse.org | Gunnar Wagenknecht [email protected] via eclipse.org | Wed, Nov 18, 7:00 PM (1 day ago)
+1
Gunnar Wagenknecht [email protected] via eclipse.org

@Emily-Jiang
Copy link
Member Author

@radcortez
Copy link

https://bugs.eclipse.org/bugs/show_bug.cgi?id=568938

Can you add the link into the description, so it gets more visibility?

@kwsutter
Copy link
Member

+1
I have reviewed the materials for this Config 2.0 release and all looks good. I will initiate the ballot review shortly.

@kwsutter kwsutter added ballot Release Review, Plan Review, Progress Review issue is now in ballot and should not be updated final Release Review, Plan Review, Progress Review issue is ready for ballot in the eyes of the Spec team labels Nov 20, 2020
@jclingan
Copy link
Collaborator

+1

@aeiras
Copy link
Contributor

aeiras commented Nov 20, 2020

We forgot to include the final step, the Result Ballot notification after the initiated ballot is sent.
can you add the step to Metrics? https://docs.google.com/document/d/1wISp-yRzQZNOHULNekxxg1U18be3v-3CRUswklcpmr8/edit

Thank YOU! the general template needs to be adjusted as well. :)

@TetianaFTV
Copy link

+1 for Jelastic

@kwsutter kwsutter added the wg-approved MP WG has approved the lifecycle issue label Dec 2, 2020
@kwsutter
Copy link
Member

kwsutter commented Dec 2, 2020

Making a similar comment that I did on the Metrics #15 and Health #14 Issues... We need the Compatible Implementation that is used to verify the CCR to be more "permanent". There is a reference to SmallRye Config 2.0. Is this available in Maven or some permanent download location? A link would be good, if that's the case. Otherwise, we should create the SmallRye Config 2.0 artifact, store it, and provide a link. Thanks.

@radcortez
Copy link

Hey @kwsutter. It is available as a commit in the repo:
smallrye/smallrye-config@679c438

The issue here is somehow the same you have with dependent specs. We can't really do a release of the implementation without having the API publicly available. Once the API is out, we cut a release from the same codebase but without the staging repo reference and publish it in Maven Central. The link can then be replaced by the permanent binary in Central. Is this acceptable?

@kwsutter
Copy link
Member

kwsutter commented Dec 3, 2020

Hey @kwsutter. It is available as a commit in the repo:
smallrye/smallrye-config@679c438

The issue here is somehow the same you have with dependent specs. We can't really do a release of the implementation without having the API publicly available. Once the API is out, we cut a release from the same codebase but without the staging repo reference and publish it in Maven Central. The link can then be replaced by the permanent binary in Central. Is this acceptable?

@radcortez, the commit tag by itself is not sufficient. This would still require someone to download the exact code and build it in the exact same way in order to produce the binary. As time goes on, these processes will get muddled and the building will become more difficult.

Any Compatible Implementation needs to have a long life. It could be a Milestone driver, or a Release Candidate driver, or even a Snapshot driver -- as long as the binary has some repository where it will live and not accidentally get deleted. The best location is Maven. But, other long-lived download repos will also suffice.

I agree that it's a chicken-and-egg problem. We struggle with this at Jakarta as well. But, we need to have a long-lived CI that can be used at a later time to verify the compatibility. As an example, Jakarta EE 9 used Glassfish 6.0-RC2 as the CI. Some of the embedded implementations used by Glassfish had not finalized their versions yet. As soon as all of these are completed, then Glassfish v6.0 (final) will be used to re-certify as the CI. A new CCR will be filed and the data for the Jakarta EE 9 CI will be updated with the new information (added to, not replaced).

@Emily-Jiang Emily-Jiang added the emo-approved EF EMO has approved the lifecycle issue label Dec 3, 2020
@radcortez
Copy link

Ok, updated the CCR with a RC release available in Central.

@Emily-Jiang
Copy link
Member Author

I double checked the released and confirmed the release used the staged Config 2.0 api (see here) and passed the TCK.

@radcortez
Copy link

radcortez commented Dec 4, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ballot Release Review, Plan Review, Progress Review issue is now in ballot and should not be updated emo-approved EF EMO has approved the lifecycle issue final Release Review, Plan Review, Progress Review issue is ready for ballot in the eyes of the Spec team pmc-approved EF PMC has approved the lifecycle issue Release Review wg-approved MP WG has approved the lifecycle issue
Projects
None yet
Development

No branches or pull requests

6 participants