Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve filtering out middle span by SpanExportingPredicate #266

Open
quaff opened this issue May 19, 2023 · 2 comments
Open

Improve filtering out middle span by SpanExportingPredicate #266

quaff opened this issue May 19, 2023 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@quaff
Copy link
Contributor

quaff commented May 19, 2023

If we have spans like

A > 
   B > 
       C
  1. with leaf span C dropped, It's expected that spans will be
A > 
   B
  1. with root span A dropped, It's expected that spans will be
B > 
   C

but a warning show up that span B has invalid parent span

  1. with middle span B dropped, we expect
A > 
   C

but got

A
C

and warning show up that span C has invalid parent span
warning by jaeger: invalid parent span IDs=c6ababd1d88b00b1; skipping clock skew adjustment.

Could we reset children's parent span id to fix such skew?

@jonatan-ivanov
Copy link
Member

jonatan-ivanov commented May 19, 2023

For the sake of documentation, I think these are related:

Could you please tell us how you "drop" spans?
Are you using an ObservationPredicate or a SpanExportingPredicate or a SpanHandler or something else?

@quaff
Copy link
Contributor Author

quaff commented May 22, 2023

For the sake of documentation, I think these are related:

Could you please tell us how you "drop" spans? Are you using an ObservationPredicate or a SpanExportingPredicate or a SpanHandler or something else?

For example I want to drop connection but want to keep it's descendants.

	@Bean
	SpanExportingPredicate noConnectionSpanExportingPredicate() {
		return span -> !span.getName().equals("connection");
	}

Sometime I want to drop connection and it's descendants, hopeful both cases are supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants