Do not leak OTLP types on public-facing API #5699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatan-ivanov
added
bug
shakuzen
reviewed
Nov 26, 2024
There was a problem hiding this comment.
Even though we didn't intend for this to be public in the first place (as far as I remember), it is probably better we do this in main so no one is broken upon upgrading a patch version. I think any changes that would follow this will likely not be applied to maintenance branches anyway.
jonatan-ivanov
force-pushed
the
do-not-leak-otlp-types
branch
from
73bb6fd to
cb271b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AggregationTemporality#toOtlpAggregationTemporalitywas not intended to be public, users should not use it. This is a breaking change.See #5733