Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store the Meter.Id instead of the Meter in KafkaMetrics #2991

Closed
jonatan-ivanov opened this issue Feb 3, 2022 · 0 comments
Closed

Store the Meter.Id instead of the Meter in KafkaMetrics #2991

jonatan-ivanov opened this issue Feb 3, 2022 · 0 comments
Labels
type: task A general task
Milestone
1.7.9

Comments

@jonatan-ivanov
Copy link
Member

KafkaMetrics keeps a reference on every Meter in order to remove them from the registry when KafkaMetrics is closed. We can store the Meter.Id instead which means a closer behavior to the way we remove Meters from the registry.
@jonatan-ivanov jonatan-ivanov added the type: task A general task label Feb 3, 2022
@jonatan-ivanov jonatan-ivanov added this to the 1.7.9 milestone Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
1.7.9
Development

No branches or pull requests
1 participant
@jonatan-ivanov