You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug KafkaMetrics uses a ScheduledExecutorService to schedule a task that refreshes the Meters based on the available Kafka Metrics. If this task fails, the scheduler will never reschedule it.
See:
If checkAndBindMetrics throws an exception ScheduledExecutorService stops scheduling.
Environment
Micrometer version: 1.7.6, 1.8.0
Micrometer registry: all/unrelated
OS: all/unrelated
Java version: all/unrelated
To Reproduce
One way reproducing it is triggering Kafka to rebalance, see #2843 (comment)
Expected behavior
If any error arises during refreshing the Meters, scheduling should not stop.
Additional context
We should not just fix the problem that causes the exception but handle and log all of the exceptions that can be thrown from that method.
The text was updated successfully, but these errors were encountered:
Describe the bug
KafkaMetrics
uses aScheduledExecutorService
to schedule a task that refreshes the Meters based on the available Kafka Metrics. If this task fails, the scheduler will never reschedule it.See:
micrometer/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/kafka/KafkaMetrics.java
Line 117 in 8e7f666
If
checkAndBindMetrics
throws an exceptionScheduledExecutorService
stops scheduling.Environment
To Reproduce
One way reproducing it is triggering Kafka to rebalance, see #2843 (comment)
Expected behavior
If any error arises during refreshing the Meters, scheduling should not stop.
Additional context
We should not just fix the problem that causes the exception but handle and log all of the exceptions that can be thrown from that method.
The text was updated successfully, but these errors were encountered: