-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add callback for device (un)loaded #149
Comments
I think they should be |
@marktsuchida how does adding this here fit in with you thoughts in #150 (comment) ? |
Actually these events cannot be generated by the app, because they can happen while loading a config file, or unloading all devices. I think it in fact makes a lot of sense to add these. |
I was looking at disabling or enabling gui elements in napari-micromanager depending on whether certain devices are loaded (https://github.com/tlambert03/napari-micromanager/pull/99) and it seems to me that this would be made much easier if there were the following callabcks were added:
deviceLoaded(device, deviceType)
deviceUnloaded(device, deviceType)
In the case of napari-micromanager this is important because state can be modified either through the GUI or by a user from a script (e..g jupyter). I imagine that this could also be helpful for a user of pycromanager where the same issue can arise.
cc @tlambert03 and @fdrgsp
The text was updated successfully, but these errors were encountered: