Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow deriving Jason.Encoder with sorted keys #195

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow deriving Jason.Encoder with sorted keys #195

wants to merge 2 commits into from

Conversation

gilbertbw
Copy link

I think this closes #170, but rather than making a change to pretty_print, I modified @derive Jasen.Encoder

@michalmuskala
Copy link
Owner

Sorry for a late reply. I wonder if a simpler approach might be to preserve the order of keys passed to only: ... and document that it will be preserved. That way the user will be in full control over what order the keys are encoded in when deriving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map key validity/order in Elixir 1.14
2 participants
@gilbertbw @michalmuskala