Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump websockets to 12.0 #445

Closed
benjiqq opened this issue Jul 26, 2024 · 3 comments · Fixed by #469
Closed

bump websockets to 12.0 #445

benjiqq opened this issue Jul 26, 2024 · 3 comments · Fixed by #469
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@benjiqq
Copy link

benjiqq commented Jul 26, 2024

websockets 12.0 has been published for a while

solana (0.34.2) depends on websockets (>=9.0,<12.0), solana (>=0.34.2,<0.35.0) requires websockets (>=9.0,<12.0).
@michaelhly
Copy link
Owner

happy to accept a PR!

@michaelhly michaelhly added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 27, 2024
@azerv1
Copy link
Contributor

azerv1 commented Nov 22, 2024 •
edited
Loading

Hello, on my fork I tried to update websockets to 12.0 with poetry and all the tests are still passing, what am I missing?

@michaelhly
Copy link
Owner

Would you mind re-opening this PR?
#464

We just have to make sure none of the integration tests break.

@michaelhly michaelhly mentioned this issue Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump websockets to 12.0 azerv1/solana-py
3 participants
@benjiqq @michaelhly @azerv1