Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugins): add undefined to plugin options check #177

Merged
merged 1 commit into from
Oct 19, 2018
Merged

fix(plugins): add undefined to plugin options check #177

merged 1 commit into from
Oct 19, 2018

Conversation

michael-ciniawsky
Copy link
Collaborator

See #154

Commit Message Summary (CHANGELOG)

  • None

Type

  • Fix

SemVer

  • Fix (:label: Patch)

Issues

Checklist

  • Lint and unit tests pass with my changes
  • I have added tests that prove my fix is effective/works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes are merged and published in downstream modules

@michael-ciniawsky michael-ciniawsky added this to the 2.0.1 milestone Oct 19, 2018
@michael-ciniawsky michael-ciniawsky changed the title fix(plugins): add undefined to plugin options check fix(plugins): add undefined to options check Oct 19, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.26% when pulling 8428ea0 on fix into 003c3d9 on master.

@michael-ciniawsky michael-ciniawsky merged commit 4349ea9 into master Oct 19, 2018
@michael-ciniawsky michael-ciniawsky deleted the fix branch October 19, 2018 01:46
@michael-ciniawsky michael-ciniawsky changed the title fix(plugins): add undefined to options check fix(plugins): add undefined to plugin options check Oct 19, 2018
@michael-ciniawsky michael-ciniawsky removed this from the 2.1.1 milestone Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: plugins semver: patch status: approved type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add undefined check
2 participants
@michael-ciniawsky @coveralls