Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Report only shows issues of current commit #13

Closed
marvin-bitterlich opened this issue Feb 4, 2016 · 10 comments
Closed

Report only shows issues of current commit #13

marvin-bitterlich opened this issue Feb 4, 2016 · 10 comments

Comments

@marvin-bitterlich
Copy link

For example:

We have a PR with 5 major and one minor issue.

Someone updated the PR to fix the minor one.

SonarQube Analysis reported no issues. Take a chocolate :-) And all issues are deleted.

What is really needed:

A report of all issues at lines changed in the PR diff. Or a report for every commit individually. Or both ;)

@mrueegg
Copy link
Contributor

mrueegg commented Feb 8, 2016

Hi,

This is of course not the intended behaviour. You should get a report with 5 major issues instead. Did this only happen once or is it reproducible? Have you seen any errors in your build log from the SonarQube plug-in?

@marvin-bitterlich
Copy link
Author

There is no error, no printout (I'm not running verbose) and is always reproducible.
All build logs should be public here http://home.kk-sc.de:8085/browse/MINECOL-JAR
For Example this build http://home.kk-sc.de:8085/browse/MINECOL-JAR9-JOB1-43/log created this comment https://bitbucket.org/cltnschlosser/minecolonies/pull-requests/152/minecol-21-needed-items-refactor/diff#comment-14289480
PRs are viewable here https://bitbucket.org/cltnschlosser/minecolonies/pull-requests/
Old comments sadly get deleted
Sonarcube is here http://home.kk-sc.de:9000/
More stuff needed to reproduce: [email protected] :)

@mrueegg
Copy link
Contributor

mrueegg commented Feb 9, 2016

Thanks. To be able to troubleshoot this, could you please run the plug-in with debug logging enabled?

mvn sonar:sonar -X -Dsonar.verbose=true ...

@marvin-bitterlich
Copy link
Author

Well first it didn't spit out anything more. And after I added debug output to gradle it littered the OAuth token everywhere. Not nice ;)
https://www.dropbox.com/s/xoku18gfdy2467m/buildlog.txt?dl=0
It is a bit long btw ;)

@mrueegg
Copy link
Contributor

mrueegg commented Feb 9, 2016

Thanks for the log. You are right, when the requests get logged we should try to obfuscate all credentials in there. I opened #14 for this.

@marvin-bitterlich
Copy link
Author

Any news on this issue?

@marvin-bitterlich
Copy link
Author

Thanks for the commit, will check out if this fixes our issues :-)

@mrueegg
Copy link
Contributor

mrueegg commented Apr 13, 2016

@Kostronor I fixed issues related to the one you reported in release 1.1.3. Could you please upgrade and try again?

@marvin-bitterlich
Copy link
Author

Sure will do!
The first comment was because github on mobile does not show commits and it looks like a close without anything...
Will report once we get some pr's going

@marvin-bitterlich
Copy link
Author

Okay, now we got out first big PR going and well, not working sadly:
https://bitbucket.org/cltnschlosser/minecolonies/pull-requests/171/transition-189/diff#comment-17959250

If you need more info, please tell

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants