-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix RaiseError test case #26
Conversation
workaround for serialize RaiseError will throws ArgumentError rather than MethodError after Julia 1.10 #25
WalkthroughThe Changes
Sequence Diagram(s)Sequence diagrams have been omitted as the changes are minor and pertain to unit test assertions. Possibly related issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- test/runtests.jl (1 hunks)
Additional comments not posted (1)
test/runtests.jl (1)
141-145
: Update the exception type in the test case to align with Julia 1.10 changes.This change correctly updates the expected exception type from
MethodError
toArgumentError
based on the version check for Julia 1.10. This ensures that the tests remain valid and reflect the changes in the language's error handling behavior.
workaround for serialize RaiseError will throws ArgumentError rather than MethodError after Julia 1.10 #25
Summary by CodeRabbit