Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PR check workflow #12

Open
GCHQ-Developer-530 opened this issue Aug 23, 2024 · 0 comments
Open

Improve PR check workflow #12

GCHQ-Developer-530 opened this issue Aug 23, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@GCHQ-Developer-530
Copy link
Contributor

Summary

Currently there's a mainly empty PR check workflow running prettier checks before a PR can be merged. This needs improving with other checks.

💬 Description

An example of what could be added:

  • Add lint to static analysis tests
  • Add audit to static analysis tests (this will need an audit command adding into the package.json first)
  • Add a new job for jest tests
  • Add a new job for Cypress tests

💰 Use value

We would know nothing has been broken immediately and not have to pull the code down locally to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Ready for dev
Development

No branches or pull requests

2 participants