From c5cfd7d84d33c412aac3655b81ae67eb8c54e33e Mon Sep 17 00:00:00 2001 From: ad9242 <116102637+ad9242@users.noreply.github.com> Date: Mon, 9 Dec 2024 17:36:24 +0000 Subject: [PATCH] fix(root): fixes issues spotted on v3 site fixes alert on getting started page and page header disappearing --- src/components/SubsectionNav/index.tsx | 12 ------------ .../get-started/install-components.mdx | 16 +++++++++------- src/templates/CoreTemplate/index.css | 4 ---- 3 files changed, 9 insertions(+), 23 deletions(-) diff --git a/src/components/SubsectionNav/index.tsx b/src/components/SubsectionNav/index.tsx index e2b436578..5be9d566e 100644 --- a/src/components/SubsectionNav/index.tsx +++ b/src/components/SubsectionNav/index.tsx @@ -128,17 +128,6 @@ const SubsectionNav: React.FC = ({ tooltip?.setExternalPopperProps({ strategy: "fixed", }); - const pageHeader = document.querySelector("ic-page-header"); - if (pageHeader && pageHeader.getAttribute("sticky-desktop-only")) { - pageHeader.classList.add("temp-remove-sticky"); - } - }; - - const handleMouseOut = () => { - const pageHeader = document.querySelector("ic-page-header"); - if (pageHeader && pageHeader.getAttribute("sticky-desktop-only")) { - pageHeader.classList.remove("temp-remove-sticky"); - } }; // eslint-disable-next-line no-undef @@ -169,7 +158,6 @@ const SubsectionNav: React.FC = ({ selected={!hasChildren && isCurrentPage(item.data.fields.slug, false)} expanded={hasChildren && isChildSelected(item)} onMouseOver={handleMouseOver} - onMouseOut={handleMouseOut} onIcTreeItemSelected={() => sessionStorage.setItem("navlinkclick", "true") } diff --git a/src/content/structured/get-started/install-components.mdx b/src/content/structured/get-started/install-components.mdx index 88a2246c2..fd14609a5 100644 --- a/src/content/structured/get-started/install-components.mdx +++ b/src/content/structured/get-started/install-components.mdx @@ -43,13 +43,15 @@ npm install @ukic/react @ukic/fonts variant="warning" > - When the ic-theme component is not implemented, components will default to - the user's system colour scheme. Please keep this in mind when styling your - application. See the{" "} - - theming guidance - {" "} - for more information. + + When the ic-theme component is not implemented, components will default to + the user's system colour scheme. Please keep this in mind when styling your + application. See the{" "} + + theming guidance + {" "} + for more information. + diff --git a/src/templates/CoreTemplate/index.css b/src/templates/CoreTemplate/index.css index 8521d7d6d..b1d74458c 100644 --- a/src/templates/CoreTemplate/index.css +++ b/src/templates/CoreTemplate/index.css @@ -60,10 +60,6 @@ video.half-width { width: 48.5%; } -ic-page-header.temp-remove-sticky { - position: static; -} - @media screen and (max-width: 768px) { .page-container { margin-bottom: var(--ic-space-xxl);