#7 Allow to receive ItemId and support calendar refresh #8
Conversation
ntlm authorization works with http1.1 protocol only
|
Sorry didn't notice this... I will to get it meeged soon |
| @@ -105,7 +105,12 @@ func (c *client) SendAndReceive(body []byte) ([]byte, error) { | |||
|
|
|||
| func applyConfig(config *Config, client *http.Client) { | |||
| if config.NTLM { | |||
| client.Transport = ntlmssp.Negotiator{} | |||
| client.Transport = ntlmssp.Negotiator{ | |||
There was a problem hiding this comment.
Could you elaborate more on this?
| } | ||
|
|
||
| // CreateMessageItem | ||
| // https://docs.microsoft.com/en-us/exchange/client-developer/web-service-reference/createitem-operation-email-message | ||
| func CreateMessageItem(c Client, m ...Message) error { | ||
| func CreateMessageItem(c Client, m ...Message) ([]ItemId, error) { |
There was a problem hiding this comment.
Could you please move ItemId from get_room_lists.go to common.go?
| RequiredAttendees: []ews.Attendees{{Attendee: requiredAttendees}}, | ||
| OptionalAttendees: []ews.Attendees{{Attendee: optionalAttendees}}, | ||
| Resources: []ews.Attendees{{Attendee: room}}, | ||
| // ReminderIsSet: duration != 0, |
There was a problem hiding this comment.
Why are you commenting these? at least you might want to pass as options instead.
There was a problem hiding this comment.
Thanks for your PR ... much appreciated.
-
Could you please update
README.mdwith the newly supported features (e.g. UpdateItem and DeleteItem operations) -
Also, can you make sure the test is passing (I think it is related to this code: -- please see my comments https://github.com/mhewedy/ews/pull/8/files#diff-5eed297ba5350ffc4dcc024fe59a15c40fc6bde8beb0bb8ff588cc19e59d4b30R45)
|
@johnwiichang Do you mind fix the failing test cases? |
#7 Allow to receive ItemId and support calendar refresh
and also support downgrade when ntlm is selected