From d05e31316cd5313e1dfba11bdcb1957d5855bc02 Mon Sep 17 00:00:00 2001 From: Riyad Preukschas Date: Sat, 13 Feb 2021 22:48:52 +0100 Subject: [PATCH] Add missing early returns in compat API [NO TESTS NEEDED] Signed-off-by: Riyad Preukschas Signed-off-by: Matthew Heon --- pkg/api/handlers/compat/containers_create.go | 1 + pkg/api/handlers/compat/system.go | 1 + 2 files changed, 2 insertions(+) diff --git a/pkg/api/handlers/compat/containers_create.go b/pkg/api/handlers/compat/containers_create.go index 6e85872b2b..4a39e9563e 100644 --- a/pkg/api/handlers/compat/containers_create.go +++ b/pkg/api/handlers/compat/containers_create.go @@ -47,6 +47,7 @@ func CreateContainer(w http.ResponseWriter, r *http.Request) { rtc, err := runtime.GetConfig() if err != nil { utils.Error(w, "unable to obtain runtime config", http.StatusInternalServerError, errors.Wrap(err, "unable to get runtime config")) + return } newImage, err := runtime.ImageRuntime().NewFromLocal(body.Config.Image) diff --git a/pkg/api/handlers/compat/system.go b/pkg/api/handlers/compat/system.go index e21ae160ab..66b4236f98 100644 --- a/pkg/api/handlers/compat/system.go +++ b/pkg/api/handlers/compat/system.go @@ -19,6 +19,7 @@ func GetDiskUsage(w http.ResponseWriter, r *http.Request) { df, err := ic.SystemDf(r.Context(), options) if err != nil { utils.InternalServerError(w, err) + return } imgs := make([]*docker.ImageSummary, len(df.Images))