Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect README re: uniqueness time? #73

Closed
jackdempsey opened this issue Jan 21, 2015 · 1 comment
Closed

Incorrect README re: uniqueness time? #73

jackdempsey opened this issue Jan 21, 2015 · 1 comment

Comments

@jackdempsey
Copy link

"For jobs scheduled in the future it is possible to set for how long the job should be unique. The job will be unique for the number of seconds configured (default 30 minutes) or until the job has been completed. Thus, the job will be unique for the shorter of the two."

the SETEX doesn't care about the job finishing, and if the args stay the same, the same hash will be used to look at the lock. So if you set it to be unique for 30 minutes but it finishes in one, how would it get enqueued again?

@jackdempsey
Copy link
Author

Trying this out a bit more now. If I have some jobs that quickly fail and go past their retry, the unique key is gone afterwards, before it's timeout would indicate. So, something del's the key I guess, it's just not obvious upon initial scan of the code, or from the readme.

Finding it 'deletes uniqueness lock on delete' in the specs helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant