Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The deprecation message is unclear and unnecessary #59

Closed
PikachuEXE opened this issue Nov 14, 2014 · 1 comment · Fixed by #61
Closed

The deprecation message is unclear and unnecessary #59

PikachuEXE opened this issue Nov 14, 2014 · 1 comment · Fixed by #61

Comments

@PikachuEXE
Copy link

I get this all the time I start my app:
This method has been deprecated. See readme for information
which is from
https://github.com/mhenrixon/sidekiq-unique-jobs/blob/master/lib/sidekiq_unique_jobs/config.rb

unclear: If I don't search through the source of all the gems I am using, I won't understand what it means
unnecessary: I use .config already, why am I still getting it?

@sullimander
Copy link

If I'm reading this right it will always warn when the gem is required due to this line:

https://github.com/mhenrixon/sidekiq-unique-jobs/blob/master/lib/sidekiq_unique_jobs/config.rb#L11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants