Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is mock_redis really a runtime dependency? #46

Closed
bradrobertson opened this issue Sep 3, 2014 · 2 comments
Closed

is mock_redis really a runtime dependency? #46

bradrobertson opened this issue Sep 3, 2014 · 2 comments

Comments

@bradrobertson
Copy link

Seems like this would be more of a dev dependency. Happy to submit a PR making that change but I wasn't sure how it's used

@mhenrixon
Copy link
Owner

Some people are using it to test locally without having to install or start redis. I agree it shouldn't be a hard dependency like it is now perhaps. Would gladly accept a pull request for it.

@phuongnd08
Copy link
Contributor

Pull request submitted. As for mock_redis, I would recommend my alternative approach: https://github.com/phuongnd08/redis_test.
I don't think redis is any where near slow to be mocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants