Sidekiq Web Pagination Broken

[chadrschroeder]

When there are more than 100 digests to display on the Sidekiq Web Unique Digests page, the following error occurs:

NoMethodError
undefined method `>' for nil:NilClass

I think this is because the @current_page value is nil. Sidekiq Web expects this variable in its paging partial:

<%# sidekiq/web/views/_paging.erb %>
<% if @current_page > 1 %>
  ...

Also, when are these unique digests purged? They remain in Redis after my jobs have completed successfully and the unique:keys set continues to increase in size.

[mhenrixon]

Regarding the first question, should not be a problem with sidekiq/web as I am not paging it yet. Would be cool to know the exact line number it goes wrong.

Regarding the second question. They should be removed upon completion or when deleted from the sidekiq web extension. BUT... I found a bug, I try to delete the wrong ones. I'll have a fix for that shortly.

[mhenrixon]

This line https://github.com/mhenrixon/sidekiq-unique-jobs/blob/master/redis/signal.lua#L12 should say: redis.call('SREM', unique_keys, unique_digest)

[chadrschroeder]

For the first question, the issue is because @count defaults to 100 here and that causes us to render the paging partial here.

[mhenrixon]

Cool, I'll add support for pagination as well while I'm at it then. Thanks for reporting

[chadrschroeder]

Thanks for the quick response.

[mhenrixon]

Should be fixed in v6.0.2 @chadrschroeder! Thanks again for taking the time to report the issue.