Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidekiq-unique-jobs not enabled from sidekiq workers #131

Closed
sanjayprabhu opened this issue Oct 14, 2015 · 1 comment
Closed

sidekiq-unique-jobs not enabled from sidekiq workers #131

sanjayprabhu opened this issue Oct 14, 2015 · 1 comment

Comments

@sanjayprabhu
Copy link

I'm on sidekiq-unique-jobs 3.0.15 (which interestingly, doesn't seem to be tagged in github). And I just ran into an issue where jobs were not being de-duplicated when enqueued from sidekiq workers. Looks like this is because the client middleware is not enabled when configuring the server middleware.

See
f4404ed#diff-3deeecb0f47a5e1af766a8ee39271b2eL8.

I can open a PR with a fix if you like. I'm working around this by manually configuring it, but it'd be great to get a 3.0.16 with this fix.

@sanjayprabhu sanjayprabhu changed the title Sidekiq Unique jobs not enabled from sidekiq workers sidekiq-unique-jobs not enabled from sidekiq workers Oct 14, 2015
@mhenrixon
Copy link
Owner

Still a problem? I wouldn't mind releasing a fixed version for this but the code pre-4.x is a mess and painful to work with so if you provide the fix I'll get it released. I'll close this for now while waiting for a pull request. Sounds fair?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants