Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint_and_test.sh script not running tests #64

Closed
matt-graham opened this issue Jul 8, 2021 · 1 comment · Fixed by #78
Closed

lint_and_test.sh script not running tests #64

matt-graham opened this issue Jul 8, 2021 · 1 comment · Fixed by #78

Comments

@matt-graham
Copy link

Submitting as part of JOSS review openjournals/joss-reviews#3397

The script scripts/lint_and_test.sh currently does not run the tests on my machine (running code as of 2d47262 on Ubuntu 20.04). It seems that the pylint check may be returning an error status which due to the set -ex call then causes the script to exit without running the scripts/test.sh script. Running scripts/test.sh directly works however.
@karink520
Copy link
Collaborator

Ah, thanks! Looks like pylint shifted under us, so we hadn't been seeing this error before. Will update.

@karink520 karink520 mentioned this issue Jul 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Joss updates mggg/ecological-inference
2 participants
@karink520 @matt-graham