nit: failure in the happy path

mgechev · Dec 4, 2024 · c17efaf · c17efaf
1 parent 57e4695
commit c17efaf
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/rule/function_result_limit.go b/rule/function_result_limit.go
@@ -32,13 +32,15 @@ func (r *FunctionResultsLimitRule) Apply(file *lint.File, arguments lint.Argumen
 			num = funcDecl.Type.Results.NumFields()
 		}
 
-		if num > r.max {
-			failures = append(failures, lint.Failure{
-				Confidence: 1,
-				Failure:    fmt.Sprintf("maximum number of return results per function exceeded; max %d but got %d", r.max, num),
-				Node:       funcDecl.Type,
-			})
+		if num <= r.max {
+			continue
 		}
+
+		failures = append(failures, lint.Failure{
+			Confidence: 1,
+			Failure:    fmt.Sprintf("maximum number of return results per function exceeded; max %d but got %d", r.max, num),
+			Node:       funcDecl.Type,
+		})
 	}
 
 	return failures