Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates-no-negated-async): not reporting failures for some cases #694

Merged
merged 1 commit into from
Jul 29, 2018
Merged

fix(templates-no-negated-async): not reporting failures for some cases #694

merged 1 commit into from
Jul 29, 2018

Conversation

rafaelss95
Copy link
Collaborator

Relates to #615, it:

  • Remove hasFix option (code and tests were updated as well);
  • Fixes all the cases described in the issue above;

About deprecate/drop this rule, I'll do another PR once I'm allowed to do so.

@rafaelss95 rafaelss95 requested a review from mgechev July 29, 2018 19:14
Copy link
Owner

@mgechev mgechev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgechev mgechev merged commit 2ffe2ea into mgechev:master Jul 29, 2018
@rafaelss95 rafaelss95 deleted the fix-templates-no-negated-async branch July 29, 2018 21:38
@mgechev mgechev added this to the Tony Hoare milestone Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants