Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in check-pipe with interpolation #416

Closed
wKoza opened this issue Sep 16, 2017 · 6 comments · Fixed by #418
Closed

Issue in check-pipe with interpolation #416

wKoza opened this issue Sep 16, 2017 · 6 comments · Fixed by #418

Comments

@wKoza
Copy link
Collaborator

wKoza commented Sep 16, 2017

By @BorntraegerMarc,

@mgechev the issue seems not to be resolved for me:

D:\projects\komed-health-web>ng lint
ERROR: src/app/chat/chat.component.html[22, 43]: The pipe operator should be surrounded by > one space on each side, i.e. " | ".

D:\projects\komed-health-web>ng --version
@angular/cli: 1.4.2

this is the HTML code:

<paper-item>
   {{ 'chat.switchToDe' | translate }}
</paper-item>

from package.json:

"codelyzer": "3.2.0",
@wKoza
Copy link
Collaborator Author

wKoza commented Sep 16, 2017

After investigation, our system of unit tests doesn't detect any problems.
But, indeed, there is a false positive in my IDE (WebStorm).

It's not a regression over the last release (v3.1.2).

@BorntraegerMarc
Copy link

@wKoza what OS are you using? I could only reproduce it with widows until now

@wKoza
Copy link
Collaborator Author

wKoza commented Sep 16, 2017

OSX, @BorntraegerMarc .

@wKoza
Copy link
Collaborator Author

wKoza commented Sep 20, 2017

Ok, there is a difference between angular compiler 4.3.6 and 4.4.1 that impacts codelyzer ... This is why our travis crashs

EDIT : After investigation, our problem seems linked to the new feature 'preserveWhitespaces'.

@mgechev
Copy link
Owner

mgechev commented Sep 20, 2017

@wKoza maybe we can run conditionally the parser using semver-dsl like we do for other API differences?

@wKoza
Copy link
Collaborator Author

wKoza commented Sep 21, 2017

Yes, we can do that !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants