Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce View Encapsulation #300

Closed
mgechev opened this issue Apr 28, 2017 · 6 comments
Closed

Enforce View Encapsulation #300

mgechev opened this issue Apr 28, 2017 · 6 comments

Comments

@mgechev
Copy link
Owner

mgechev commented Apr 28, 2017

Enforce ViewEncapsulation.Emulated or ViewEncapsulation.Native.

This rule is good for first time contributors.

I'd love to assist to the one willing to take the feature.

@GregOnNet
Copy link
Contributor

GregOnNet commented Apr 28, 2017

I would be honored to take this task to get into this topic.
So if you like assign this task to me.

Kinds from SF Airport

@mgechev
Copy link
Owner Author

mgechev commented Apr 28, 2017

I can't assign it to you since you're not yet a collaborator. I'll assign it to myself to show that there's someone working on it.

@mgechev mgechev self-assigned this Apr 28, 2017
@GregOnNet
Copy link
Contributor

Nice, thank you.

@GregOnNet
Copy link
Contributor

Hi,

I did my first steps writing the TSLint rule. :-)
see first try

I need some help concerning NgWalker.
I want to output the position of ViewEncapsulation.None if it has been set. (see spec)
Unfortunately I don't know how I can walk through the AST to point to that node.

@mgechev Could you assist me in that question, please?

Kind Regards
Gregor

@mgechev
Copy link
Owner Author

mgechev commented May 3, 2017

@GregOnNet good job! You can take a look at this function. encapsulation.name.text contains also the position of the node.

@GregOnNet
Copy link
Contributor

GregOnNet commented May 3, 2017

I thank you very much. Your hint has helped me a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants