fix(rule): template-click-events-have-key-events - support pseudo eve…

…nts (#893)
mgechev · Sep 19, 2019 · 5b57bd6 · 5b57bd6
1 parent 5a80e90
commit 5b57bd6
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/templateClickEventsHaveKeyEventsRule.ts b/src/templateClickEventsHaveKeyEventsRule.ts
@@ -56,8 +56,9 @@ class TemplateVisitorCtrl extends BasicTemplateAstVisitor {
     if (isInteractiveElement(el)) {
       return;
     }
-
-    const hasKeyEvent = el.outputs.some(output => output.name === 'keyup' || output.name === 'keydown' || output.name === 'keypress');
+    const hasKeyEvent = el.outputs.some(
+      output => output.name.startsWith('keyup') || output.name.startsWith('keydown') || output.name.startsWith('keypress')
+    );
 
     if (hasKeyEvent) {
       return;

diff --git a/test/templateClickEventsHaveKeyEventsRule.spec.ts b/test/templateClickEventsHaveKeyEventsRule.spec.ts
@@ -158,6 +158,18 @@ describe(ruleName, () => {
       assertSuccess(ruleName, source);
     });
 
+    it('should work when click events are associated with key pseudo events', () => {
+      const source = `
+        @Component({
+          template: \`
+            <div (click)="onClick()" (keyup.enter)="onKeyup()"></div>
+          \`
+        })
+        class Bar {}
+      `;
+      assertSuccess(ruleName, source);
+    });
+
     it('should work when click events are passed to custom element', () => {
       const source = `
         @Component({