From 1de358161d9c01b2347f6e42c4b2ab17bff9a4be Mon Sep 17 00:00:00 2001 From: Arul Ajmani Date: Tue, 7 Jan 2025 16:57:37 -0500 Subject: [PATCH] roachtest: terminate gossip roachtest on VM migration We've seen unexpected clock jumps in this test's failures. Live migrations are one explanation for this, so let's disable them for this test. NB: Not closing out the linked issue as it happened on Azure, and this termination policy only applies to GCE. Informs https://github.com/cockroachdb/cockroach/issues/130737 Release note: None --- pkg/cmd/roachtest/tests/gossip.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/cmd/roachtest/tests/gossip.go b/pkg/cmd/roachtest/tests/gossip.go index 570ea1c99155..4895e6fd05a7 100644 --- a/pkg/cmd/roachtest/tests/gossip.go +++ b/pkg/cmd/roachtest/tests/gossip.go @@ -23,6 +23,7 @@ import ( "github.com/cockroachdb/cockroach/pkg/cmd/roachtest/option" "github.com/cockroachdb/cockroach/pkg/cmd/roachtest/registry" "github.com/cockroachdb/cockroach/pkg/cmd/roachtest/roachtestutil" + "github.com/cockroachdb/cockroach/pkg/cmd/roachtest/spec" "github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test" "github.com/cockroachdb/cockroach/pkg/gossip" "github.com/cockroachdb/cockroach/pkg/roachprod" @@ -182,7 +183,7 @@ SELECT node_id r.Add(registry.TestSpec{ Name: "gossip/chaos/nodes=9", Owner: registry.OwnerKV, - Cluster: r.MakeClusterSpec(9), + Cluster: r.MakeClusterSpec(9, spec.TerminateOnMigration()), CompatibleClouds: registry.AllExceptAWS, Suites: registry.Suites(registry.Nightly), Leases: registry.MetamorphicLeases,