From d67ee3c482309b7b759d4144d1c11bbcd5b20358 Mon Sep 17 00:00:00 2001 From: Xin Hao Zhang Date: Mon, 30 Dec 2024 13:48:21 -0500 Subject: [PATCH] server: cleanup creation of storeids slice for span stats The creation of the storeIDs slice should be done after iterating through range descriptors, not at the end of each iteration. This commit fixes a misplacement of this code block. Epic: none Release note: None --- pkg/server/span_stats_server.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/pkg/server/span_stats_server.go b/pkg/server/span_stats_server.go index d66b27b21e1f..8b6b6d4cc6f1 100644 --- a/pkg/server/span_stats_server.go +++ b/pkg/server/span_stats_server.go @@ -330,16 +330,16 @@ func (s *systemStatusServer) statsForSpan( return nil, err } } + } - spanStats.StoreIDs = make([]roachpb.StoreID, 0, len(storeIDs)) - for storeID := range storeIDs { - spanStats.StoreIDs = append(spanStats.StoreIDs, storeID) - } - sort.Slice(spanStats.StoreIDs, func(i, j int) bool { - return spanStats.StoreIDs[i] < spanStats.StoreIDs[j] - }) - + spanStats.StoreIDs = make([]roachpb.StoreID, 0, len(storeIDs)) + for storeID := range storeIDs { + spanStats.StoreIDs = append(spanStats.StoreIDs, storeID) } + sort.Slice(spanStats.StoreIDs, func(i, j int) bool { + return spanStats.StoreIDs[i] < spanStats.StoreIDs[j] + }) + // If we still have some remaining ranges, request range stats for the current batch. if len(fullyContainedKeysBatch) > 0 { // Obtain stats for fully contained ranges via RangeStats.