-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cr8 timeit unable to handle comments with semicolon in individual line #380
Comments
cr8 currently doesn't really have any sophisticated query splitting logic. Lines 108 to 129 in 3729a35
I could pull in the crate antrl grammar to recognize multiple statements correctly but that would have the downside that cr8 would become bundled to concrete versions of the grammar which I'd rather avoid given that one of the main use-cases is BWC testing it's important that cr8 stays mostly CrateDB version independant. That said, I'd accept a PR that tries to handle |
Describe the bug
Trying to use
cr8 timeit
with complex queries with comments I get failures depending on whether they contain semicolons on the same line where the comment is started.To Reproduce
Pipe the following:
-->
This instead works:
Expected behavior
Runs
select 1;
without aSQLParseException
cr8 Version: (
cr8 --version
)0.26.1
The text was updated successfully, but these errors were encountered: