Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cr8 timeit unable to handle comments with semicolon in individual line #380

Open
hlcianfagna opened this issue Jul 31, 2024 · 1 comment

Comments

@hlcianfagna
Copy link
Contributor

Describe the bug
Trying to use cr8 timeit with complex queries with comments I get failures depending on whether they contain semicolons on the same line where the comment is started.

To Reproduce
Pipe the following:

/* 
comment 2 ;
*/
select 1;

-->

SQLParseException[line 1:1: mismatched input '/' expecting {'SELECT'

This instead works:

/* comment 2 ; */
select 1;

Expected behavior
Runs select 1; without a SQLParseException

cr8 Version: (cr8 --version)

0.26.1

@mfussenegger
Copy link
Owner

cr8 currently doesn't really have any sophisticated query splitting logic.
See

cr8/cr8/misc.py

Lines 108 to 129 in 3729a35

def as_statements(lines: Iterator[str]) -> Iterator[str]:
"""Create an iterator that transforms lines into sql statements.
Statements within the lines must end with ";"
The last statement will be included even if it does not end in ';'
>>> list(as_statements(['select * from', '-- comments are filtered', 't;']))
['select * from t']
>>> list(as_statements(['a;', 'b', 'c;', 'd', ' ']))
['a', 'b c', 'd']
"""
lines = (l.strip() for l in lines if l)
lines = (l for l in lines if l and not l.startswith('--'))
parts = []
for line in lines:
parts.append(line.rstrip(';'))
if line.endswith(';'):
yield ' '.join(parts)
parts.clear()
if parts:
yield ' '.join(parts)

I could pull in the crate antrl grammar to recognize multiple statements correctly but that would have the downside that cr8 would become bundled to concrete versions of the grammar which I'd rather avoid given that one of the main use-cases is BWC testing it's important that cr8 stays mostly CrateDB version independant.

That said, I'd accept a PR that tries to handle /* style comments if it's not too complex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants