Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSX support #253

Closed
vves opened this issue Feb 14, 2023 · 4 comments
Closed

OSX support #253

vves opened this issue Feb 14, 2023 · 4 comments
Labels
duplicate This issue or pull request already exists

Comments

@vves
Copy link
Contributor

vves commented Feb 14, 2023

While the library works on my linux issue, I and some others here in the US would like to use the library on an OSX instance. Fix the network adapter for OSX.
@Apollon77
Copy link
Collaborator

What exactly is the issue? I use macos all the day with node-matter and it works.

Yes it is currently logging some error for "advertisements on wrong interfaces" but the github version already "ignores" these errors and it works.But yes selecting the right interfaces would be a topic for optimization

@vves
Copy link
Contributor Author

vves commented Feb 14, 2023

It's a 3 line change to fix. I'll post the pull request and you can decide if it's worth it.

@Apollon77
Copy link
Collaborator

Cool :-)

@vves
Copy link
Contributor Author

vves commented Feb 17, 2023

Should we close this as duplicate of #11

@Apollon77 Apollon77 added the duplicate This issue or pull request already exists label Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vves @Apollon77