fix: support mmdc on windows #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is, I just didn't test this properly over there. I assumed since things like invoking cargo or other tools work this would work too but I guess not. Thanks! |
|
Looks like you need to run |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if Windows platform support is of any importance but I encountered an issue where
mmdccannot be found on Windows. This is due to this issue whereCommand::new()on Windows works in this way: "if the file has a different extension, a filename including the extension needs to be provided, otherwise the file won’t be found.".Since mmdc on Windows is an alias for the
mmdc.cmdscript and not anexe, this updates the name used to find the mmdc tool.