Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another case of maximum call stack size #44

Closed
jliebrand opened this issue Oct 27, 2018 · 5 comments
Closed

Another case of maximum call stack size #44

jliebrand opened this issue Oct 27, 2018 · 5 comments
Assignees
Milestone

Comments

@jliebrand
Copy link
Contributor

We're still seeing errors in production with maximum call stack size reached.

Here's an example set of coords that cause it:
https://gist.github.com/jliebrand/5b00599bee190e28d26ead782c35e988

@mfogel mfogel self-assigned this Oct 27, 2018
@jliebrand
Copy link
Contributor Author

@jliebrand
Copy link
Contributor Author

And another one:
https://gist.github.com/jliebrand/0ebe812a5ded2564c0c6693435ba382d

(let me know if you need more)

@mfogel
Copy link
Owner

mfogel commented Oct 31, 2018

Thank you for the examples! Probably no more needed at the moment. I just need to catch up on fixing the bugs... I'm planning to get time this upcoming weekend to hopefully deep dive into at least one more.

@mfogel
Copy link
Owner

mfogel commented Nov 9, 2018

Ok I was able to simplify the first set of coordinates down to just:

{
  "type": "FeatureCollection",
  "features": [
    {
      "type": "Feature",
      "properties": {},
      "geometry": {
        "type": "Polygon",
        "coordinates": [[[0, 0], [3, -2], [5, 0], [0, 0]]]
      }
    },
    {
      "type": "Feature",
      "properties": {},
      "geometry": {
        "type": "Polygon",
        "coordinates": [[[0, 0], [3, -1], [4, 0], [0, 0]]]
      }
    },
    {
      "type": "Feature",
      "properties": {},
      "geometry": {
        "type": "Polygon",
        "coordinates": [[[0, 0], [3, -3], [5, 0], [0, 0]]]
      }
    }
  ]
}

for which executing a union on still triggers a 'maximum call stack exceeded' error.

@mfogel mfogel added this to the v0.9.1 milestone Nov 9, 2018
@mfogel mfogel closed this as completed in b8d903d Nov 9, 2018
@mfogel
Copy link
Owner

mfogel commented Nov 9, 2018

@jliebrand The commit I just placed on master fixes things for me for the three sets of coords on this ticket, as well as the ones in #45 and #46. If the fix doesn't work for any of them for you, please reopen. And please shoot me more bugs as you run across them.

I plan to release a new minor version to npm with the latest bugfixes in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants