diff --git a/test/numbers.jl b/test/numbers.jl index 64b3174fe484f..019ffcffcb695 100644 --- a/test/numbers.jl +++ b/test/numbers.jl @@ -2770,7 +2770,12 @@ let types = (Base.BitInteger_types..., BigInt, Bool, Complex{Int}, Complex{UInt}, Complex32, Complex64, Complex128) for S in types for op in (+, -) - T = @inferred Base.promote_op(op, S) + if S === Float16 # type instability here? + @test_broken @inferred Base.promote_op(op, S) + T = Base.promote_op(op, S) + else + T = @inferred Base.promote_op(op, S) + end t = @inferred op(one(S)) @test T === typeof(t) end @@ -2780,8 +2785,15 @@ let types = (Base.BitInteger_types..., BigInt, Bool, for R in types, S in types for op in (+, -, *, /, ^) - T = @inferred Base.promote_op(op, R, S) - t = @inferred op(one(R), one(S)) + if R in (Float16, Complex{Float16}) || S in (Float16, Complex{Float16}) + @test_broken @inferred Base.promote_op(op, R, S) + T = Base.promote_op(op, R, S) + @test_broken @inferred op(one(R), one(S)) + t = op(one(R), one(S)) + else + T = @inferred Base.promote_op(op, R, S) + t = @inferred op(one(R), one(S)) + end @test T === typeof(t) end end @@ -2792,7 +2804,12 @@ let types = (Base.BitInteger_types..., BigInt, Bool, Float16, Float32, Float64, BigFloat) for S in types, T in types for op in (<, >, <=, >=, (==)) - @test @inferred(Base.promote_op(op, S, T)) === Bool + if S === Float16 || T === Float16 + @test_broken @inferred(Base.promote_op(op, S, T)) + @test Base.promote_op(op, S, T) === Bool + else + @test @inferred(Base.promote_op(op, S, T)) === Bool + end end end end