Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"frame.Frame.parseHeader: The flac library test cases do not yet include any audio files with block size 192." #55

Closed
lpar opened this issue Jan 8, 2023 · 2 comments

Comments

@lpar
Copy link

lpar commented Jan 8, 2023

frame.Frame.parseHeader: The flac library test cases do not yet include any audio files with block size 192. If possible please consider contributing this audio sample to improve the reliability of the test cases.

Hit this message processing a file. I'd be happy to provide the file, but it's copyrighted material ripped from a CD. Would that work to extract the appropriate test blocks?

@mewmew
Copy link
Member

mewmew commented Jan 9, 2023

Hit this message processing a file. I'd be happy to provide the file, but it's copyrighted material ripped from a CD. Would that work to extract the appropriate test blocks?

Hej @lpar,

Thanks for reaching out to us! I think all our test cases are currently Create Commons licensed or released within the Public Domain.

As to the extent copyright law, my insights are fortunately limited.

I think we can close this issue as a the IETF test case suit also included samples with block size 192. Ref: #54 (comment)

That way we can resolve the issue of copyright.

Wish you all the best @lpar and a great year to come!

@mewmew
Copy link
Member

mewmew commented Jan 9, 2023

Closing as duplicate of #54 (comment) (which also contains test samples for block size 192).

Cheers,
Robin

@mewmew mewmew closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants