Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: map foo/:id/bar to foo/:id?join=bar #484

Open
tafelnl opened this issue Jan 14, 2019 · 1 comment
Open

Suggestion: map foo/:id/bar to foo/:id?join=bar #484

tafelnl opened this issue Jan 14, 2019 · 1 comment
Assignees

Comments

@tafelnl
Copy link

tafelnl commented Jan 14, 2019

Just started using this library and already love it too much. ❤️

As title states. This follows the more common approaches and makes a little bit more sense.

A minor thing, and maybe hard the implement in the backend (didn't take a look at it (yet) to be honest).
So don't worry about it too much, just a little suggestion.

@mevdschee
Copy link
Owner

mevdschee commented Jan 14, 2019

Thank you for your kind words. You may add this functionality by implementing a rewriterule. Note that there can be multiple join paths in the query, so it wont be an ideal match for a rewriterule (you will have to model multiple join paths somehow).

@mevdschee mevdschee removed the v2 label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants