Booleans parsed from environment in utterly confusing ways

[bzed]

Hi,

there are various "boolean" style config settings, which are parsed in different ways. For example:

qryn/common.js

Line 104 in 9da57a7

module.exports.isOmitTablesCreation = () => process.env.OMIT_CREATE_TABLES === '1'

at least compares the value with 1. Not sure why it needs a lambda, but it works. According to the documentation the default is false, so I would expect the right setting to be 'true' and not 1.

qryn/common.js

Line 129 in 9da57a7

module.exports.readonly = process.env.READONLY || false

Even worse. READONLY=false in the environment will evaluate to true. 😿 Basically everywhere if (readonly) is being used.

I did not go trough the other boolean style config options, but please find a unified way to set such options and document it.

Thanks,

Bernd

[lmangani]

Thanks for raising this good point @bzed we need to sanitize bool settings in a standardized fashion.
We'll add this to the quick roadmap to improve the experience.

[akvlad]

@bzed the problem you mentioned was... well, taken under control
since 3.2.14 all the boolean env vars should be:

• no, n, false, 0 and missing variable is considered as false
• yes, y, true, 1 is considered as true

I hope the solution satisfies everyone.
Thanks for the heads up.

[lmangani]

Closing as completed! Feel free to reopen if the issue persists