-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Headers should be lower-cased #35
Comments
Interesting, the |
Let's keep this open while the original ring bug is open. |
Thanks for discovering this bug. The error was in the spec. It looks like when I converted it to markdown the "lowercased" adjective was added to the response header definition erroneously. I've since fixed this and the spec should now be correct. |
Yeah, thanks for the clarification! |
The original fix was reverted in #37 |
Currently, ring-http-response uses header names like
"Content-Type"
. However, the ring spec defines that headers should be lower-cased: https://github.com/ring-clojure/ring/blob/master/SPEC.md#headers-1This is important in case there are middleware in the pipeline that expect to be able to parse eg. the content-type header, and are looking for it under the
"content-type"
name.I think we should label this fix as a breaking change, since somebody might've been relying on the exact naming of the headers.
The text was updated successfully, but these errors were encountered: